~/f/gzip/RPMS.2 ~/f/gzip ~/f/gzip RPMS.2/gzip-1.14-1.1.x86_64.rpm RPMS/gzip-1.14-1.1.x86_64.rpm differ: byte 225, line 1 Comparing gzip-1.14-1.1.x86_64.rpm to gzip-1.14-1.1.x86_64.rpm comparing the rpm tags of gzip --- old-rpm-tags +++ new-rpm-tags @@ -131 +131 @@ -/usr/bin/gzip 8cb2b6f62a0393f13c30ca2ead45769486ce04aa9f92f564d1105cb14a71f913 0 +/usr/bin/gzip a7357ab704f8cdd67c2f78f59df73544854bdf8c8a9973d713737a1ae8bdd09d 0 comparing rpmtags comparing RELEASE comparing PROVIDES comparing scripts comparing filelist comparing file checksum creating rename script RPM file checksum differs. Extracting packages /usr/bin/gzip differs in ELF sections --- old /usr/bin/gzip (objdump) +++ new /usr/bin/gzip (objdump) @@ -253,10 +253,10 @@ 1278 74196909 00000200 fa020000 00000000 t.i............. Contents of section .rela.dyn: 1288 a8460100 00000000 08000000 00000000 .F.............. - 1298 e08e0000 00000000 b0460100 00000000 .........F...... - 12a8 08000000 00000000 30b20000 00000000 ........0....... + 1298 f08f0000 00000000 b0460100 00000000 .........F...... + 12a8 08000000 00000000 60b10000 00000000 ........`....... 12b8 b8460100 00000000 08000000 00000000 .F.............. - 12c8 f0b10000 00000000 c0460100 00000000 .........F...... + 12c8 20b10000 00000000 c0460100 00000000 ........F...... 12d8 08000000 00000000 c8f20000 00000000 ................ 12e8 c8460100 00000000 08000000 00000000 .F.............. 12f8 cef20000 00000000 d0460100 00000000 .........F...... @@ -388,7 +388,7 @@ 1ad8 00a40200 00000000 d0530100 00000000 .........S...... 1ae8 08000000 00000000 00520100 00000000 .........R...... 1af8 e8530100 00000000 08000000 00000000 .S.............. - 1b08 d0bd0000 00000000 d84f0100 00000000 .........O...... + 1b08 10bd0000 00000000 d84f0100 00000000 .........O...... 1b18 06000000 09000000 00000000 00000000 ................ 1b28 e04f0100 00000000 06000000 0d000000 .O.............. 1b38 00000000 00000000 e84f0100 00000000 .........O...... @@ -584,33 +584,33 @@ Contents of section .plt.got: 3470 ff25821b 01006690 .%....f. Contents of section .text: - 3480 4883c001 e9aa8400 00833de0 a40d0000 H.........=..... + 3480 4883c001 e9ea8300 00833de0 a40d0000 H.........=..... 3490 7540833d efa40d00 00488b0d 10a50d00 u@.=.....H...... 34a0 0f84e800 00004c8d 0db7bb00 004c8d05 ......L......L.. 34b0 b3bb0000 50488b3d 842b0100 488d1595 ....PH.=.+..H... 34c0 bf000031 c051be02 000000e8 20ffffff ...1.Q...... ... - 34d0 585abf01 000000e8 24a30000 833d99a4 XZ......$....=.. - 34e0 0d000075 50833d9c a40d0000 0f85b485 ...uP.=......... + 34d0 585abf01 000000e8 e4a20000 833d99a4 XZ...........=.. + 34e0 0d000075 50833d9c a40d0000 0f85f484 ...uP.=......... 34f0 0000488b 357f9b0d 00488b15 402b0100 ..H.5....H..@+.. 3500 4889f748 2b3d669b 0d004803 3d579b0d H..H+=f...H.=W.. - 3510 00e86322 0000488b 35232b01 00bf0a00 ..c"..H.5#+..... + 3510 00e84f21 0000488b 35232b01 00bf0a00 ..O!..H.5#+..... 3520 00005ae9 e8fcffff 8b3d461d 01004159 ..Z......=F...AY - 3530 e9d52900 00488b0d 042b0100 ba040000 ..)..H...+...... + 3530 e9c12800 00488b0d 042b0100 ba040000 ..(..H...+...... 3540 00be0100 00004158 488d3d3c bb0000e9 ......AXH.=<.... - 3550 8cfeffff 8b3d269b 0d00e8b1 85000089 .....=&......... - 3560 050f1d01 0085c00f 88398500 00e9fc84 .........9...... - 3570 00008b3d c89f0d00 e883a200 00488d3d ...=.........H.= - 3580 f8ba0000 e8e52200 00e944ff ffff4c8d ......"...D...L. + 3550 8cfeffff 8b3d269b 0d00e8f1 84000089 .....=&......... + 3560 050f1d01 0085c00f 88798400 00e93c84 .........y....<. + 3570 00008b3d c89f0d00 e843a200 00488d3d ...=.....C...H.= + 3580 f8ba0000 e8d12100 00e944ff ffff4c8d ......!...D...L. 3590 0d7bba00 004c8d05 d5ba0000 e913ffff .{...L.......... - 35a0 ff833de4 a30d0000 0f849285 000039c8 ..=...........9. + 35a0 ff833de4 a30d0000 0f84d284 000039c8 ..=...........9. 35b0 734c8d50 018915a1 9a0d0048 8d153e9a sL.P.......H..>. 35c0 09000fb6 14028b05 909a0d00 3b05869a ............;... 35d0 0d008854 242e0f83 db020000 8d480189 ...T$........H.. 35e0 0d779a0d 00488d0d 149a0900 440fb61c .w...H......D... - 35f0 014489d8 e98f8500 00e892fb ffffbf01 .D.............. - 3600 000000e8 e8900000 89c2ebba 4883c448 ............H..H - 3610 89d05b41 5ec36681 7c242e1f 9e0f849b ..[A^.f.|$...... - 3620 85000066 817c242e 504b7519 833d299a ...f.|$.PKu..=). + 35f0 014489d8 e9cf8400 00e892fb ffffbf01 .D.............. + 3600 000000e8 c8900000 89c2ebba 4883c448 ............H..H + 3610 89d05b41 5ec36681 7c242e1f 9e0f84db ..[A^.f.|$...... + 3620 84000066 817c242e 504b7519 833d299a ...f.|$.PKu..=). 3630 0d000275 10813dc1 99090050 4b03040f ...u..=....PK... 3640 84840800 0066817c 242e1f1e 0f845408 .....f.|$.....T. 3650 00006681 7c242e1f 9d0f84f7 08000066 ..f.|$.........f @@ -619,28 +619,28 @@ 3680 0f852d01 0000488b 0d23a30d 004c8d05 ..-...H..#...L.. 3690 cc9e0d00 488d15f5 b9000048 8b3d9e29 ....H......H.=.) 36a0 0100be02 00000031 c0e842fd ffffc705 .......1..B..... - 36b0 889e0d00 01000000 baffffff ffe9e986 ................ + 36b0 889e0d00 01000000 baffffff ffe92986 ..............). 36c0 0000410f b6f248c7 c7ffffff ff44895c ..A...H......D.\ - 36d0 2408e836 35000044 8b5c2408 e99b8600 $..65..D.\$..... - 36e0 0031f648 8d7c242e 44895c24 08e83e8f .1.H.|$.D.\$..>. + 36d0 2408e846 36000044 8b5c2408 e9db8500 $..F6..D.\$..... + 36e0 0031f648 8d7c242e 44895c24 08e87e8e .1.H.|$.D.\$..~. 36f0 0000448b 5c240844 0fb7f08b 055b990d ..D.\$.D.....[.. 3700 003b0551 990d000f 83f10000 008d5001 .;.Q..........P. 3710 89154699 0d00488d 15e39809 000fb61c ..F...H......... 3720 028b0535 990d003b 052b990d 000f83b4 ...5...;.+...... 3730 0200008d 50018915 20990d00 488d15bd ....P... ...H... 3740 9809000f b60402c1 e00809c3 4189d941 ............A..A - 3750 39de0f84 2c860000 44895c24 08488b0d 9...,...D.\$.H.. + 3750 39de0f84 6c850000 44895c24 08488b0d 9...l...D.\$.H.. 3760 4ca20d00 be020000 0031c052 488b3dcd L........1.RH.=. 3770 2801004c 8d05e69d 0d00488d 1547be00 (..L......H..G.. 3780 004156e8 68fcffff 833df5a1 0d000159 .AV.h....=.....Y 3790 c705a69d 0d000100 00005e44 8b5c2408 ..........^D.\$. - 37a0 0f8fde85 0000e90d ffffff85 d20f89f8 ................ + 37a0 0f8f1e85 0000e90d ffffff85 d20f8938 ...............8 37b0 85000048 8d1d4698 0900807c 242e0075 ...H..F....|$..u 37c0 134585db 0f849902 00004183 c3010f84 .E........A..... 37d0 b0020000 833d95a1 0d00000f 84550200 .....=.......U.. 37e0 00833d58 9d0d0000 750ac705 4c9d0d00 ..=X....u...L... - 37f0 02000000 bafeffff ffe9ad85 000031ff ..............1. - 3800 44895c24 08e8e68e 0000448b 5c240889 D.\$......D.\$.. + 37f0 02000000 bafeffff ffe9ed84 000031ff ..............1. + 3800 44895c24 08e8c68e 0000448b 5c240889 D.\$......D.\$.. 3810 c3e90bff ffff8b05 40980d00 3b053698 ........@...;.6. 3820 0d000f83 37010000 8d500189 152b980d ....7....P...+.. 3830 00488d15 c8970900 0fb60402 8844242c .H...........D$, @@ -650,30 +650,30 @@ 3870 c04489f6 c1e00809 c6833dec a00d0000 .D........=..... 3880 4189f60f 85f40200 0084db0f 85310300 A............1.. 3890 00410fb6 f24489f7 44895c24 14448854 .A...D..D.\$.D.T - 38a0 2408e866 33000044 0fb65424 08448b5c $..f3..D..T$.D.\ - 38b0 2414e9b1 840000bf 01000000 89542408 $............T$. - 38c0 e82b8e00 008b5424 084189c3 e920fdff .+....T$.A... .. + 38a0 2408e876 34000044 0fb65424 08448b5c $..v4..D..T$.D.\ + 38b0 2414e9f1 830000bf 01000000 89542408 $............T$. + 38c0 e80b8e00 008b5424 084189c3 e920fdff ......T$.A... .. 38d0 ff833da4 19010000 751a833d aba00d00 ..=.....u..=.... 38e0 000f8499 00000083 3d8aa00d 00000f85 ........=....... 38f0 8c000000 410fb6f2 48c7c7ff ffffff44 ....A...H......D - 3900 895c2414 44885424 08e8ff32 0000440f .\$.D.T$...2..D. - 3910 b6542408 448b5c24 14e95484 000031ff .T$.D.\$..T...1. + 3900 895c2414 44885424 08e80f34 0000440f .\$.D.T$...4..D. + 3910 b6542408 448b5c24 14e99483 000031ff .T$.D.\$......1. 3920 be0a0000 0044895c 24144889 3dd78e09 .....D.\$.H.=... 3930 00488d7c 242e4488 54243144 88542408 .H.|$.D.T$1D.T$. - 3940 c6442430 0844894c 2432e8e1 8c000044 .D$0.D.L$2.....D - 3950 0fb65424 08448b5c 2414e9ff 83000031 ..T$.D.\$......1 - 3960 ff44895c 24144488 542408e8 808d0000 .D.\$.D.T$...... + 3940 c6442430 0844894c 2432e821 8c000044 .D$0.D.L$2.!...D + 3950 0fb65424 08448b5c 2414e93f 83000031 ..T$.D.\$..?...1 + 3960 ff44895c 24144488 542408e8 608d0000 .D.\$.D.T$..`... 3970 448b5c24 14440fb6 542408e9 bcfeffff D.\$.D..T$...... 3980 833dfd96 0d00010f 8f67ffff ff488d3d .=.......g...H.= - 3990 ac970d00 e8977f00 00488d15 60960900 .........H..`... + 3990 ac970d00 e8d77e00 00488d15 60960900 ......~..H..`... 39a0 488d0d99 9b0d0049 89c64889 c68b05a9 H......I..H..... 39b0 960d003b 059f960d 0073458d 78010fb6 ...;.....sE.x... 39c0 0402893d 94960d00 88064883 c60184c0 ...=......H..... 39d0 0f841401 00004839 ce72d248 8d3dbebb ......H9.r.H.=.. - 39e0 0000e892 1f000031 ff44895c 2408e8fd .......1.D.\$... + 39e0 0000e87e 1e000031 ff44895c 2408e8dd ...~...1.D.\$... 39f0 8c000044 8b5c2408 c1e008e9 4afdffff ...D.\$.....J... 3a00 31ff4889 74241844 895c2414 44885424 1.H.t$.D.\$.D.T$ - 3a10 08e8da8c 0000488b 74241844 8b5c2414 ......H.t$.D.\$. + 3a10 08e8ba8c 0000488b 74241844 8b5c2414 ......H.t$.D.\$. 3a20 488d0d19 9b0d0044 0fb65424 08488d15 H......D..T$.H.. 3a30 cc950900 eb92488b 0d739f0d 00488b3d ......H..s...H.= 3a40 fc250100 31c04c8d 05139b0d 00488d15 .%..1.L......H.. @@ -683,15 +683,15 @@ 3a80 3dfdffff 833de19e 0d000074 20833ddc =....=.....t .=. 3a90 9e0d0000 0f84b600 0000833d 9f9a0d00 ...........=.... 3aa0 00750ac7 05939a0d 00020000 00bafdff .u.............. - 3ab0 ffffe9f4 820000bf 01000000 e82f8c00 ............./.. + 3ab0 ffffe934 820000bf 01000000 e80f8c00 ...4............ 3ac0 004189c3 e9f8fcff ff31ff44 895c2414 .A.......1.D.\$. - 3ad0 44885424 08e8168c 0000448b 5c241444 D.T$......D.\$.D + 3ad0 44885424 08e8f68b 0000448b 5c241444 D.T$......D.\$.D 3ae0 0fb65424 08e980fd ffff84db 75404c89 ..T$........u@L. - 3af0 f744895c 24184488 542414e8 307e0000 .D.\$.D.T$..0~.. + 3af0 f744895c 24184488 542414e8 707d0000 .D.\$.D.T$..p}.. 3b00 4889c748 89442408 e863f6ff ff488b74 H..H.D$..c...H.t 3b10 24084c89 f7488d50 01e832f8 ffff440f $.L..H.P..2...D. - 3b20 b6542414 448b5c24 18e94482 00004c89 .T$.D.\$..D...L. - 3b30 f74429f6 44895c24 14448854 2408e8ed .D).D.\$.D.T$... + 3b20 b6542414 448b5c24 18e98481 00004c89 .T$.D.\$......L. + 3b30 f74429f6 44895c24 14448854 2408e82d .D).D.\$.D.T$..- 3b40 8a000044 8b5c2414 440fb654 2408eb9e ...D.\$.D..T$... 3b50 488b0d59 9e0d0048 8b3de224 010031c0 H..Y...H.=.$..1. 3b60 4c8d05f9 990d0048 8d1522bb 0000be02 L......H.."..... @@ -701,54 +701,54 @@ 3ba0 14488d15 c8b90000 44885424 08e83ef8 .H......D.T$..>. 3bb0 ffff448b 5c241444 0fb65424 08e9c7fc ..D.\$.D..T$.... 3bc0 ffff488d 7c242cbe 02000000 44895c24 ..H.|$,.....D.\$ - 3bd0 14448854 2408e855 8a000044 8b5c2414 .D.T$..U...D.\$. + 3bd0 14448854 2408e895 89000044 8b5c2414 .D.T$......D.\$. 3be0 440fb654 2408e9a6 fcffff31 ff4c894c D..T$......1.L.L - 3bf0 24184489 5c241444 88542408 e8ef8a00 $.D.\$.D.T$..... + 3bf0 24184489 5c241444 88542408 e8cf8a00 $.D.\$.D.T$..... 3c00 00440fb6 54240844 8b5c2414 4c8b4c24 .D..T$.D.\$.L.L$ - 3c10 18e93881 000031ff 4c894c24 1844895c ..8...1.L.L$.D.\ - 3c20 24144488 542408e8 c48a0000 440fb654 $.D.T$......D..T - 3c30 2408448b 5c24144c 8b4c2418 e9e38000 $.D.\$.L.L$..... + 3c10 18e97880 000031ff 4c894c24 1844895c ..x...1.L.L$.D.\ + 3c20 24144488 542408e8 a48a0000 440fb654 $.D.T$......D..T + 3c30 2408448b 5c24144c 8b4c2418 e9238000 $.D.\$.L.L$..#.. 3c40 004885c0 783d4531 c0488905 f0930d00 .H..x=E1.H...... - 3c50 4c8905f1 930d00e9 a2800000 31ff4489 L...........1.D. - 3c60 5c241444 88542408 e8838a00 00440fb6 \$.D.T$......D.. - 3c70 54240844 8b5c2414 489848c1 e018e966 T$.D.\$.H.H....f - 3c80 80000083 3de69c0d 00007427 833dad98 ....=.....t'.=.. + 3c50 4c8905f1 930d00e9 e27f0000 31ff4489 L...........1.D. + 3c60 5c241444 88542408 e8638a00 00440fb6 \$.D.T$..c...D.. + 3c70 54240844 8b5c2414 489848c1 e018e9a6 T$.D.\$.H.H..... + 3c80 7f000083 3de69c0d 00007427 833dad98 ....=.....t'.=.. 3c90 0d000075 0ac705a1 980d0002 00000066 ...u...........f - 3ca0 0f6f0509 e900000f 29059293 0d00e94b .o......)......K - 3cb0 80000048 8b0df69c 0d00488b 3d7f2301 ...H......H.=.#. /usr/bin/gzip differs in assembler output --- old /usr/bin/gzip (disasm) +++ new /usr/bin/gzip (disasm) @@ -1461,70 +1461,39 @@ jmp updcrc.cold: - sub %rcx,%rdx + sub %rcx,%rbp lea (%rdi,%rcx,1),%rsi mov $something,%ecx - mov %r8d,offset(%rsp) - lea offset(%rsp),%rdi - mov %rdx,(%rsp) + mov %rsp,%rdi + mov %rbp,%rdx call <__memcpy_chk@plt> - mov (%rsp),%rdx - mov offset(%rsp),%esi - lea offset(%rip),%r9 # - mov %rsi,%r8 - lea offset(,%rdx,8),%ecx - xor offset(%rsp),%rsi - shr %cl,%r8d - xor %ecx,%ecx - cmp $something,%rdx - cmovae %ecx,%r8d - lea -offset(,%rdx,8),%ecx + lea offset(,%rbp,8),%ecx + xor %eax,%eax + mov %ebx,%esi + shr %cl,%ebx + xor (%rsp),%rsi + cmp $something,%rbp + cmovae %eax,%ebx + lea -offset(,%rbp,8),%ecx xor %eax,%eax - mov %rsi,%r10 + lea offset(%rip),%rdx # + mov %rsi,%r8 mov %rax,%rdi add $something,%rax - shr %cl,%r10 + shr %cl,%r8 shl $something,%rdi sub $something,%ecx - movzbl %r10b,%r10d - add %r10,%rdi - xor (%r9,%rdi,4),%r8d - cmp %rax,%rdx + movzbl %r8b,%r8d + add %r8,%rdi + xor (%rdx,%rdi,4),%ebx + cmp %rax,%rbp jne jmp - mov %r8d,%eax - xor (%rdi,%rcx,1),%rax - lea offset(%rip),%r9 # - add $something,%rcx - mov %rax,%rsi - shr $something,%rax - movzbl %sil,%r8d - mov (%r9,%rax,4),%eax - mov %rsi,%rbx - xor offset(%r9,%r8,4),%eax - mov %rsi,%r8 - shr $something,%r8 - movzbl %r8b,%r8d - xor offset(%r9,%r8,4),%eax - mov %rsi,%r8 - shr $something,%r8 - movzbl %r8b,%r8d - xor offset(%r9,%r8,4),%eax - mov %rsi,%r8 - shr $something,%r8 - movzbl %r8b,%r8d - xor offset(%r9,%r8,4),%eax - mov %rsi,%r8 - shr $something,%r8 - movzbl %r8b,%r8d - xor offset(%r9,%r8,4),%eax - mov %rsi,%r8 - movzbl %bh,%esi - shr $something,%r8 - movzbl %r8b,%r8d - xor offset(%r9,%r8,4),%eax - xor offset(%r9,%rsi,4),%eax - mov %eax,%r8d + mov %rdi,%rsi + mov %rbp,%rdx + mov %ebx,%edi + call + mov %eax,%ebx jmp fill_inbuf.cold: @@ -2071,32 +2040,6 @@ lea offset(%rip),%r8 # jmp -crc32_update_no_xor_pclmul.cold: - sub %r10,%r11 - mov %r10,%rdx - mov %r9,%rsi - lea offset(%r11),%rdi - call - vmovdqa offset(%rsp),%xmm0 - vmovdqa offset(%rip),%xmm1 # - vpclmulhqhqdq %xmm1,%xmm0,%xmm2 - vpclmullqlqdq %xmm1,%xmm0,%xmm0 - vpxor %xmm2,%xmm0,%xmm0 - vpxor offset(%rsp),%xmm0,%xmm0 - jmp - mov %r9,%rdi - mov %r11,offset(%rsp) - vmovdqa %xmm2,(%rsp) - mov %rdx,offset(%rsp) - call - vmovdqa (%rsp),%xmm2 - vpxor offset(%rsp),%xmm2,%xmm2 - mov offset(%rsp),%r10 - mov offset(%rsp),%r11 - mov %rax,%r9 - vmovdqa %xmm2,offset(%rsp) - jmp - ct_tally.cold: cmp $something,%edx je @@ -3193,6 +3136,126 @@ pop %r15 ret +crc32_update_no_xor_pclmul: + sub $something,%rsp + vmovd %edi,%xmm0 + mov $something,%ecx + mov %fs:0x28,%rax + mov %rax,offset(%rsp) + xor %eax,%eax + mov %rsp,%rdi + cmp $something,%rdx + rep stos %eax,%es:(%rdi) + lea offset(%rsp),%rdi + mov $something,%ecx + rep stos %eax,%es:(%rdi) + lea offset(%rsp),%rax + jbe + vmovdqu offset(%rsi),%xmm4 + vpxor (%rsi),%xmm0,%xmm0 + mov %rsi,%rcx + lea (%rdx,%rsi,1),%rdi + vmovdqu offset(%rsi),%xmm2 + vmovdqu offset(%rsi),%xmm3 + vmovdqa offset(%rip),%xmm1 # + vpclmulhqhqdq %xmm1,%xmm0,%xmm5 + vpclmullqlqdq %xmm1,%xmm0,%xmm0 + add $something,%rcx + mov %rdi,%r8 + vpxor %xmm0,%xmm5,%xmm0 + vpclmulhqhqdq %xmm1,%xmm4,%xmm5 + vpclmullqlqdq %xmm1,%xmm4,%xmm4 + vpxor %xmm4,%xmm5,%xmm4 + vpclmulhqhqdq %xmm1,%xmm2,%xmm5 + vpclmullqlqdq %xmm1,%xmm2,%xmm2 + vpxor %xmm5,%xmm2,%xmm2 + vpclmulhqhqdq %xmm1,%xmm3,%xmm5 + vpclmullqlqdq %xmm1,%xmm3,%xmm3 + vpxor %xmm3,%xmm5,%xmm3 + vpxor (%rcx),%xmm0,%xmm0 + vpxor offset(%rcx),%xmm4,%xmm4 + vpxor offset(%rcx),%xmm2,%xmm2 + vpxor offset(%rcx),%xmm3,%xmm3 + sub %rcx,%r8 + cmp $something,%r8 + ja + lea -offset(%rdx),%rdi + vmovdqa %xmm0,offset(%rsp) + mov %rdi,%rcx + vmovdqa %xmm4,offset(%rsp) + shr $something,%rcx + vmovdqa %xmm2,offset(%rsp) + imul $something,%rcx,%rcx + vmovdqa %xmm3,offset(%rsp) + sub %rcx,%rsi + lea -offset(%rcx,%rdx,1),%rdx + add %edi,%ecx + sub $something,%rsi + mov %ecx,%ecx + lea offset(%rsp),%rdi + rep movsb %ds:(%rsi),%es:(%rdi) + jmp + mov %rax,%rdi + mov %rdx,%rcx + rep movsb %ds:(%rsi),%es:(%rdi) + vpxor offset(%rsp),%xmm0,%xmm0 + vmovdqa %xmm0,offset(%rsp) + vmovdqa offset(%rip),%xmm2 # + mov %rax,%rsi + cmp $something,%rdx overalldiffered=1 (number of pkgs that are not bit-by-bit identical: 0 is good) overall=1